Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing include for Official builds #329

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Fix missing include for Official builds #329

merged 1 commit into from
Aug 15, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 15, 2018 •
edited
Loading

Fix for a build issue introduced for official builds from brave/brave-browser#184

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy self-assigned this Aug 15, 2018
emerick
emerick approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlexeyBarabash
AlexeyBarabash approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit 9f1bf7e into master Aug 15, 2018
@bbondy bbondy deleted the dark-theme-fix branch August 20, 2018 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbondy @emerick @AlexeyBarabash